Skip to content

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Jun 17, 2024

Tidy up RETURN_VALUE.

  • Renames _POP_FRAME as _RETURN_VALUE since it returns a value as well as popping a frame
  • Makes the returned value explicit in the instruction definition.

@markshannon
Copy link
Member Author

The four failures are pre-existing failures.

@markshannon markshannon merged commit 274f844 into python:main Jun 17, 2024
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
* Rename _POP_FRAME to _RETURN_VALUE as it returns a value as well as popping a frame.

* Remove remaining _POP_FRAMEs
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
* Rename _POP_FRAME to _RETURN_VALUE as it returns a value as well as popping a frame.

* Remove remaining _POP_FRAMEs
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
* Rename _POP_FRAME to _RETURN_VALUE as it returns a value as well as popping a frame.

* Remove remaining _POP_FRAMEs
@markshannon markshannon deleted the tidy-up-return-value branch August 6, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants