Skip to content

[3.13] gh-121988: Fix test hang when pyrepl is not available (GH-121990) #122064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2024
Merged

[3.13] gh-121988: Fix test hang when pyrepl is not available (GH-121990) #122064

merged 1 commit into from
Jul 20, 2024

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 20, 2024 •
edited by bedevere-app bot
Loading

Also explicitly fail the test if we timeout while waiting for output so
that this failure mode is caught earlier.
(cherry picked from commit a09e215)

Co-authored-by: Sam Gross colesbury@gmail.com

@colesbury @miss-islington
pythongh-121988: Fix test hang when pyrepl is not available (pythonGH…
671190f 
…-121990)

Also explicitly fail the test if we timeout while waiting for output so
that this failure mode is caught earlier.
(cherry picked from commit a09e215)

Co-authored-by: Sam Gross <colesbury@gmail.com>
This was referenced Jul 20, 2024
Closed
Merged
@bedevere-app bedevere-app bot added skip news tests Tests in the Lib/test dir awaiting review labels Jul 20, 2024
@pablogsal pablogsal enabled auto-merge (squash) July 20, 2024 14:04
@pablogsal pablogsal merged commit bd5121b into python:3.13 Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miss-islington @pablogsal @colesbury