Skip to content

gh-122534 Speedup float pack / unpack #122535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

gh-122534 Speedup float pack / unpack #122535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0e4a730
Speed up float pack and unpack
Jul 25, 2024
7207b51
add always_inline to help gcc optimizing the code
Jul 31, 2024
da52114
blurb
Jul 31, 2024
7deb4da
remove yet unused _PyFloat_InitState
Jul 31, 2024
4e8ef91
update blurb
Jul 31, 2024
83c1fa0
update blurb
Jul 31, 2024
64101d4
update blurb
Jul 31, 2024
c450f74
update blurb
Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions Include/internal/pycore_floatobject.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ extern "C" {

/* runtime lifecycle */

extern void _PyFloat_InitState(PyInterpreterState *);
extern PyStatus _PyFloat_InitTypes(PyInterpreterState *);
extern void _PyFloat_FiniType(PyInterpreterState *);

Expand All @@ -25,11 +24,6 @@ enum _py_float_format_type {
_py_float_format_ieee_little_endian,
};

struct _Py_float_runtime_state {
enum _py_float_format_type float_format;
enum _py_float_format_type double_format;
};




Expand Down
1 change: 0 additions & 1 deletion Include/internal/pycore_runtime.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,6 @@ typedef struct pyruntimestate {
} audit_hooks;

struct _py_object_runtime_state object_state;
struct _Py_float_runtime_state float_state;
struct _Py_unicode_runtime_state unicode_state;
struct _types_runtime_state types;

Expand Down
4 changes: 0 additions & 4 deletions Include/internal/pycore_runtime_init.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,10 +152,6 @@ extern PyTypeObject _PyExc_MemoryError;
.stoptheworld = { \
.is_global = 1, \
}, \
.float_state = { \
.float_format = _py_float_format_unknown, \
.double_format = _py_float_format_unknown, \
}, \
.types = { \
.next_version_tag = 1, \
}, \
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/C API/2024-07-26-21-45-44.gh-issue-122534.Mu5JSt.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Improve performance of :c:func:`PyFloat_Pack4`, :c:func:`PyFloat_Pack8`, :c:func:`PyFloat_Unpack4` and :c:func:`PyFloat_Unpack8`.

Loading