Skip to content

Conversation

msprotz
Copy link
Contributor

@msprotz msprotz commented Aug 1, 2024

…ASHLIB_HASHES appears twice as a #define in confdefs.h -- try to fix this
@picnixz picnixz changed the title gh-122571: Fix configure.ac gh-122571: Remove duplicated definitions of PY_BUILTIN_HASHLIB_HASHES in configure.ac Aug 2, 2024
@bedevere-app
Copy link

bedevere-app bot commented Aug 2, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@gpshead gpshead self-requested a review August 4, 2024 23:07
@msprotz
Copy link
Contributor Author

msprotz commented Aug 5, 2024

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Aug 5, 2024

Thanks for making the requested changes!

@erlend-aasland: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from erlend-aasland August 5, 2024 19:50
@erlend-aasland
Copy link
Contributor

Thanks, this looks good to me! I won't be able to verify it on my laptop until tomorrow evening, so I'll hold off merging until then.

@erlend-aasland erlend-aasland self-assigned this Aug 5, 2024
@msprotz
Copy link
Contributor Author

msprotz commented Aug 5, 2024

Thanks, this looks good to me! I won't be able to verify it on my laptop until tomorrow evening, so I'll hold off merging until then.

No problem, thanks for the prompt review!

@erlend-aasland erlend-aasland enabled auto-merge (squash) August 6, 2024 23:08
@erlend-aasland
Copy link
Contributor

Thank you so much for finding and fixing this, @msprotz!

@erlend-aasland erlend-aasland added the needs backport to 3.13 bugs and security fixes label Aug 6, 2024
@erlend-aasland
Copy link
Contributor

I'm not sure we should backport this to 3.12.

@erlend-aasland erlend-aasland merged commit b5e142b into python:main Aug 6, 2024
@miss-islington-app

This comment was marked as outdated.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 6, 2024
…SHES in configure.ac (pythonGH-122572)

The redefinition in confdefs.h can cause issues with the
AX_CHECK_COMPILE_FLAG macro.
(cherry picked from commit b5e142b)

Co-authored-by: Jonathan Protzenko <protz@microsoft.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 6, 2024

GH-122763 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 6, 2024
brandtbucher pushed a commit to brandtbucher/cpython that referenced this pull request Aug 7, 2024
…SHES in configure.ac (python#122572)

The redefinition in confdefs.h can cause issues with the
AX_CHECK_COMPILE_FLAG macro.
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
…SHES in configure.ac (python#122572)

The redefinition in confdefs.h can cause issues with the
AX_CHECK_COMPILE_FLAG macro.
Yhg1s pushed a commit that referenced this pull request Sep 2, 2024
…ASHES in configure.ac (GH-122572) (#122763)

gh-122571: Remove duplicate definition of PY_BUILTIN_HASHLIB_HASHES in configure.ac (GH-122572)

The redefinition in confdefs.h can cause issues with the
AX_CHECK_COMPILE_FLAG macro.
(cherry picked from commit b5e142b)

Co-authored-by: Jonathan Protzenko <protz@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants