-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
gh-122571: Remove duplicated definitions of PY_BUILTIN_HASHLIB_HASHES
in configure.ac
#122572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ASHLIB_HASHES appears twice as a #define in confdefs.h -- try to fix this
Misc/NEWS.d/next/Build/2024-08-01-10-51-02.gh-issue-122571.fpA1xD.rst
Outdated
Show resolved
Hide resolved
PY_BUILTIN_HASHLIB_HASHES
in configure.ac
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
I have made the requested changes; please review again |
Thanks for making the requested changes! @erlend-aasland: please review the changes made to this pull request. |
Thanks, this looks good to me! I won't be able to verify it on my laptop until tomorrow evening, so I'll hold off merging until then. |
No problem, thanks for the prompt review! |
Thank you so much for finding and fixing this, @msprotz! |
I'm not sure we should backport this to 3.12. |
This comment was marked as outdated.
This comment was marked as outdated.
…SHES in configure.ac (pythonGH-122572) The redefinition in confdefs.h can cause issues with the AX_CHECK_COMPILE_FLAG macro. (cherry picked from commit b5e142b) Co-authored-by: Jonathan Protzenko <protz@microsoft.com>
GH-122763 is a backport of this pull request to the 3.13 branch. |
…SHES in configure.ac (python#122572) The redefinition in confdefs.h can cause issues with the AX_CHECK_COMPILE_FLAG macro.
…SHES in configure.ac (python#122572) The redefinition in confdefs.h can cause issues with the AX_CHECK_COMPILE_FLAG macro.
…ASHES in configure.ac (GH-122572) (#122763) gh-122571: Remove duplicate definition of PY_BUILTIN_HASHLIB_HASHES in configure.ac (GH-122572) The redefinition in confdefs.h can cause issues with the AX_CHECK_COMPILE_FLAG macro. (cherry picked from commit b5e142b) Co-authored-by: Jonathan Protzenko <protz@microsoft.com>
Uh oh!
There was an error while loading. Please reload this page.