GH-117224: Move the body of a few large-ish micro-ops into helper functions #122601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
How does this differ from #117224, which ended being unhelpful / inconclusive? |
Member
Author
|
I'd forgotten about that issue. |
markshannon
changed the title
iritkatriel
approved these changes
Aug 2, 2024
Member
Author
|
Failures are due to network issues on embedded platforms |
Contributor
|
Out of curiosity, I ran benchmarking on this PR. While for most configurations, the difference is within the noise, for the JIT on Windows, it's around 1.09x faster. nbody alone is like 1.92x faster, and nbody is also notably the benchmark that spends the most time percentage-wise in the JIT. So, somehow this was a magic unlock for JIT performance on Windows-only -- if we can better understand why, maybe this will help elsewhere. Cc: @brandtbucher |
brandtbucher
pushed a commit
to brandtbucher/cpython
that referenced
this pull request
Aug 7, 2024
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the bodies of
_LOAD_GLOBAL,GET_ANEXT,GET_AWAITABLEandLOAD_NAMEinto helper functions.