Skip to content

[3.13] gh-122798: Make tests for warnings in the re module more strict (GH-122799) #122804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2024
Merged

[3.13] gh-122798: Make tests for warnings in the re module more strict (GH-122799) #122804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 40 additions & 11 deletions Lib/test/test_re.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1116,47 +1116,76 @@ def test_not_literal(self):

def test_possible_set_operations(self):
s = bytes(range(128)).decode()
with self.assertWarns(FutureWarning):
with self.assertWarnsRegex(FutureWarning, 'Possible set difference') as w:
p = re.compile(r'[0-9--1]')
self.assertEqual(w.filename, __file__)
self.assertEqual(p.findall(s), list('-./0123456789'))
with self.assertWarnsRegex(FutureWarning, 'Possible set difference') as w:
self.assertEqual(re.findall(r'[0-9--2]', s), list('-./0123456789'))
self.assertEqual(w.filename, __file__)

self.assertEqual(re.findall(r'[--1]', s), list('-./01'))
with self.assertWarns(FutureWarning):

with self.assertWarnsRegex(FutureWarning, 'Possible set difference') as w:
p = re.compile(r'[%--1]')
self.assertEqual(w.filename, __file__)
self.assertEqual(p.findall(s), list("%&'()*+,-1"))
with self.assertWarns(FutureWarning):

with self.assertWarnsRegex(FutureWarning, 'Possible set difference ') as w:
p = re.compile(r'[%--]')
self.assertEqual(w.filename, __file__)
self.assertEqual(p.findall(s), list("%&'()*+,-"))

with self.assertWarns(FutureWarning):
with self.assertWarnsRegex(FutureWarning, 'Possible set intersection ') as w:
p = re.compile(r'[0-9&&1]')
self.assertEqual(w.filename, __file__)
self.assertEqual(p.findall(s), list('&0123456789'))
with self.assertWarns(FutureWarning):
with self.assertWarnsRegex(FutureWarning, 'Possible set intersection ') as w:
self.assertEqual(re.findall(r'[0-8&&1]', s), list('&012345678'))
self.assertEqual(w.filename, __file__)

with self.assertWarnsRegex(FutureWarning, 'Possible set intersection ') as w:
p = re.compile(r'[\d&&1]')
self.assertEqual(w.filename, __file__)
self.assertEqual(p.findall(s), list('&0123456789'))

self.assertEqual(re.findall(r'[&&1]', s), list('&1'))

with self.assertWarns(FutureWarning):
with self.assertWarnsRegex(FutureWarning, 'Possible set union ') as w:
p = re.compile(r'[0-9||a]')
self.assertEqual(w.filename, __file__)
self.assertEqual(p.findall(s), list('0123456789a|'))
with self.assertWarns(FutureWarning):

with self.assertWarnsRegex(FutureWarning, 'Possible set union ') as w:
p = re.compile(r'[\d||a]')
self.assertEqual(w.filename, __file__)
self.assertEqual(p.findall(s), list('0123456789a|'))

self.assertEqual(re.findall(r'[||1]', s), list('1|'))

with self.assertWarns(FutureWarning):
with self.assertWarnsRegex(FutureWarning, 'Possible set symmetric difference ') as w:
p = re.compile(r'[0-9~~1]')
self.assertEqual(w.filename, __file__)
self.assertEqual(p.findall(s), list('0123456789~'))
with self.assertWarns(FutureWarning):

with self.assertWarnsRegex(FutureWarning, 'Possible set symmetric difference ') as w:
p = re.compile(r'[\d~~1]')
self.assertEqual(w.filename, __file__)
self.assertEqual(p.findall(s), list('0123456789~'))

self.assertEqual(re.findall(r'[~~1]', s), list('1~'))

with self.assertWarns(FutureWarning):
with self.assertWarnsRegex(FutureWarning, 'Possible nested set ') as w:
p = re.compile(r'[[0-9]|]')
self.assertEqual(w.filename, __file__)
self.assertEqual(p.findall(s), list('0123456789[]'))
with self.assertWarnsRegex(FutureWarning, 'Possible nested set ') as w:
self.assertEqual(re.findall(r'[[0-8]|]', s), list('012345678[]'))
self.assertEqual(w.filename, __file__)

with self.assertWarns(FutureWarning):
with self.assertWarnsRegex(FutureWarning, 'Possible nested set ') as w:
p = re.compile(r'[[:digit:]|]')
self.assertEqual(w.filename, __file__)
self.assertEqual(p.findall(s), list(':[]dgit'))

def test_search_coverage(self):
Expand Down