gh-121404: split compiler's push/pop_inlined_comprehension_state into codegen and compiler parts #123021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e into codegen and compiler parts
iritkatriel
requested review from
JelleZijlstra,
carljm and
markshannon
as code owners
iritkatriel
added
skip news
interpreter-core
iritkatriel
added
the
🔨 test-with-refleak-buildbots
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 7c5ae2a 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-refleak-buildbots
iritkatriel
commented
Aug 15, 2024
markshannon
reviewed
Aug 15, 2024
| push_inlined_comprehension_state(struct compiler *c, location loc, | ||
| PySTEntryObject *entry, | ||
| inlined_comprehension_state *state) | ||
| compiler_tweak_inlined_comprehension_scopes(struct compiler *c, location loc, |
There was a problem hiding this comment.
I'm not sure what this does, maybe change "tweak" to something more informative?
Can we also add a comment as we why we need to "tweak" the "state", rather than creating a new symbol table entry for the comprehension?
There was a problem hiding this comment.
I have this issue to look into this area - let's discuss there. #122985
There was a problem hiding this comment.
(Sorry, I already clicked auto-merge before your comment came through).
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
…e into codegen and compiler parts (python#123021)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preparation for the division of the compiler into codegen functions and compiler-state manipulation functions.