Skip to content

Conversation

@picnixz
Copy link
Member

@picnixz picnixz commented Aug 22, 2024

@picnixz
Copy link
Member Author

picnixz commented Aug 22, 2024

Huh, so that's weird. Is it because of the / that we have this?

fnmatch.fnmatchcase(WindowsPath('usr/bin'), 'usr/bin') == False
fnmatch.fnmatchcase('usr/bin', 'usr/bin') == True

Mmh. I'm not really sure then what do to here. Let me think.

cc @barneygale

@picnixz picnixz marked this pull request as draft August 22, 2024 08:05
@picnixz picnixz marked this pull request as ready for review August 22, 2024 11:54
@picnixz
Copy link
Member Author

picnixz commented Aug 26, 2024

See #123215 (comment) for the rationale of closing this PR.

@picnixz picnixz closed this Aug 26, 2024
@picnixz picnixz deleted the fnmatchcase-pathlike-123215 branch August 26, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant