Skip to content

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Aug 23, 2024

@picnixz picnixz changed the title gh-121303: more compiler_* -> codegen_*, class_body and comprehensions gh-121404: more compiler_* -> codegen_*, class_body and comprehensions Aug 23, 2024
iritkatriel and others added 2 commits August 23, 2024 14:54
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
#define IS_INTERACTIVE(C) compiler_is_interactive(C)
#define IS_NESTED_SCOPE(C) compiler_is_nested_scope(C)
#define SCOPE_TYPE(C) compiler_scope_type(C)
#define QUALNAME(C) compiler_qualname(C)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see why you are adding this macro; it fits the pattern.

But OOI, why do we have all these macros in the first place?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why originally, but I think it will be handy for customizing the compiler after I finish the split. We'll see.

Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants