GH-73991: Prune pathlib.Path.copy() and copy_into() arguments
#123337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove ignore and on_error arguments from
pathlib.Path.copy[_into](), because these arguments are under-designed. Specifically:shutil.copytree(), but it's not clear how it should apply when the user copies a non-directory. We've changed the callback signature from theshutilversion, but I'm not confident the new signature is as good as it can be.shutil.copytree()'s error handling, which is to accumulate exceptions and raise a singleshutil.Errorat the end. It's not obvious which solution is better.Additionally, these arguments may be challenging to implement in future user subclasses of
PathBase, which might utilise a native recursive copying method.No news because
copy()andcopy_into()are unreleased.📚 Documentation preview 📚: https://cpython-previews--123337.org.readthedocs.build/