Skip to content

Conversation

@Eclips4
Copy link
Member

@Eclips4 Eclips4 commented Sep 26, 2024

@Eclips4 Eclips4 requested review from picnixz and vstinner September 26, 2024 15:06
@Eclips4 Eclips4 changed the title Fix reference leak in _datetimemodule.c gh-124606: Fix reference leak in _datetimemodule.c Sep 26, 2024
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! (though I find the gotos a bit too hard to follow in this specific function). Do you want to run the refleak build bots?

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I confirm that ./python -m test test_datetime -R 3:3 no longer leaks with this change.

For the PR title, you may refer to datetime_fromisoformat() which is more precise ;-)

@vstinner
Copy link
Member

Do you want to run the refleak build bots?

It's not needed. I tested manually.

@Eclips4 Eclips4 changed the title gh-124606: Fix reference leak in _datetimemodule.c gh-124606: Fix reference leak in error path in datetime_fromisoformat in _datetimemodule.c Sep 26, 2024
@Eclips4 Eclips4 enabled auto-merge (squash) September 26, 2024 15:18
@Eclips4 Eclips4 disabled auto-merge September 26, 2024 15:23
@Eclips4 Eclips4 enabled auto-merge (squash) September 26, 2024 15:26
@Eclips4 Eclips4 merged commit 9c98fda into python:main Sep 26, 2024
39 checks passed
@Eclips4 Eclips4 deleted the issue-124606 branch September 26, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants