Skip to content

Conversation

Ketchp
Copy link

@Ketchp Ketchp commented Oct 9, 2024

Implementation of changes to slash_no_default, slash_with_default rules.

Joined alternatives together by using group and action for positive lookahead.

@ghost
Copy link

ghost commented Oct 9, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Oct 9, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@pablogsal
Copy link
Member

pablogsal commented Oct 9, 2024

Unfortunately I don't think this is a good idea, specially with that void cast over there. There is no measurable performance benefit and makes the grammar more unreadable so I'm -1

@lysnikolaou WDYT?

@efimov-mikhail
Copy link
Member

efimov-mikhail commented Oct 12, 2024

I agree with @pablogsal. Such change makes very little sense, since there is no improvements at all. Providing less lines of grammar at any cost is not a goal.

W/o hacks like (void *) conversions it may be appropriate, but with them it is not, IMO.

@pablogsal
Copy link
Member

Closing as per above. Thanks a lot for the suggestion @Ketchp and sorry we could not go with it this time

@pablogsal pablogsal closed this Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants