gh-116938: Fix dict.update docstring and remove erraneous full stop from dict documentation
#125421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skirpichev
approved these changes
Oct 14, 2024
methane
approved these changes
Oct 14, 2024
methane
added
docs
|
Thanks @Prometheus3375 for catching these issues |
|
LGTM, but I don't merge this yet to ensure a chance for other core developers to review. |
|
@methane 2 weeks have passed, nobody else reviewed. |
AA-Turner
approved these changes
Oct 29, 2024
AA-Turner
changed the title
dict.update docstring and remove redundant period from dict web documentationdict.update docstring and remove erraneous full stop from dict documentation
|
Thanks @Prometheus3375 for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 29, 2024
…l stop from `dict` documentation (pythonGH-125421) (cherry picked from commit 5527c40) Co-authored-by: Prometheus3375 <35541026+Prometheus3375@users.noreply.github.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 29, 2024
…l stop from `dict` documentation (pythonGH-125421) (cherry picked from commit 5527c40) Co-authored-by: Prometheus3375 <35541026+Prometheus3375@users.noreply.github.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
|
GH-126150 is a backport of this pull request to the 3.13 branch. |
|
GH-126151 is a backport of this pull request to the 3.12 branch. |
AA-Turner
added a commit
that referenced
this pull request
Oct 29, 2024
…ll stop from `dict` documentation (GH-125421) (#126151) gh-116938: Fix `dict.update` docstring and remove erraneous full stop from `dict` documentation (GH-125421) (cherry picked from commit 5527c40) Co-authored-by: Prometheus3375 <35541026+Prometheus3375@users.noreply.github.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
AA-Turner
added a commit
that referenced
this pull request
Oct 29, 2024
…ll stop from `dict` documentation (GH-125421) (#126150) gh-116938: Fix `dict.update` docstring and remove erraneous full stop from `dict` documentation (GH-125421) (cherry picked from commit 5527c40) Co-authored-by: Prometheus3375 <35541026+Prometheus3375@users.noreply.github.com> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
…l stop from `dict` documentation (python#125421) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
…l stop from `dict` documentation (python#125421) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made:
dictanddict.updateregarding the positional argument they accept #125213.MutableMapping.updatetodict.updatedocstring. Also changeddict/iterabletomapping/iterableasEcan be indeed any mapping object, not justdict.dictanddict.updatetreat the first argument as a mapping when it has attributekeyswithout attribute__getitem__#116938📚 Documentation preview 📚: https://cpython-previews--125421.org.readthedocs.build/