Skip to content

gh-125510: Wrap unused argument in _sqlite/connection.c with Py_UNUSED #125509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

gh-125510: Wrap unused argument in _sqlite/connection.c with Py_UNUSED #125509

wants to merge 1 commit into from

Conversation

rruuaanng
Copy link
Contributor

@rruuaanng rruuaanng commented Oct 15, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 15, 2024
Closed
@rruuaanng rruuaanng changed the title gh-125508: Wrap unused argument in _sqlite/connection.c with Py_UNUSED gh-125510: Wrap unused argument in _sqlite/connection.c with Py_UNUSED Oct 15, 2024
@bedevere-app bedevere-app bot mentioned this pull request Oct 15, 2024
Closed
@ZeroIntensity
Copy link
Member

IIRC, unused* marks something to the compiler as unused anyway, so this PR is purely cosmetic.

@rruuaanng
Copy link
Contributor Author

It does not actually use __attribute__((unused)), which for the GNU compiler does not suppress the warning.

@rruuaanng rruuaanng deleted the gh125508 branch October 15, 2024 11:17
@ZeroIntensity
Copy link
Member

The attribute only applies to functions, not parameters, AFAIK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Assignees

No one assigned

Labels

awaiting review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rruuaanng @ZeroIntensity @erlend-aasland