Skip to content

gh-125514: fix bug in test_traceback utility. Specify exception types in except: clauses #125516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2024
Merged

gh-125514: fix bug in test_traceback utility. Specify exception types in except: clauses #125516

merged 1 commit into from
Oct 15, 2024

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Oct 15, 2024 •
edited by bedevere-app bot
Loading

@iritkatriel iritkatriel added type-bug An unexpected behavior, bug, or error skip news stdlib Standard Library Python modules in the Lib/ directory labels Oct 15, 2024
@bedevere-app bedevere-app bot mentioned this pull request Oct 15, 2024
Closed
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review labels Oct 15, 2024
ncoghlan
ncoghlan approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iritkatriel iritkatriel added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Oct 15, 2024
@iritkatriel iritkatriel merged commit 55c4f4c into python:main Oct 15, 2024
41 checks passed
@miss-islington-app
Copy link

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 15, 2024
@iritkatriel @miss-islington
pythongh-125514: fix bug in test_traceback utility. Specify exception…
7292acf 
… types in except: clauses (pythonGH-125516)

(cherry picked from commit 55c4f4c)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 15, 2024
@iritkatriel @miss-islington
pythongh-125514: fix bug in test_traceback utility. Specify exception…
aa472eb 
… types in except: clauses (pythonGH-125516)

(cherry picked from commit 55c4f4c)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 15, 2024

GH-125524 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 15, 2024
@bedevere-app
Copy link

bedevere-app bot commented Oct 15, 2024

GH-125525 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 15, 2024
iritkatriel added a commit that referenced this pull request Oct 15, 2024
@miss-islington @iritkatriel
[3.12] gh-125514: fix bug in test_traceback utility. Specify exceptio…
26725d1 
…n types in except: clauses (GH-125516) (#125525)

gh-125514: fix bug in test_traceback utility. Specify exception types in except: clauses (GH-125516)
(cherry picked from commit 55c4f4c)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
iritkatriel added a commit that referenced this pull request Oct 15, 2024
@miss-islington @iritkatriel
[3.13] gh-125514: fix bug in test_traceback utility. Specify exceptio…
3b8477b 
…n types in except: clauses (GH-125516) (#125524)

gh-125514: fix bug in test_traceback utility. Specify exception types in except: clauses (GH-125516)
(cherry picked from commit 55c4f4c)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

Assignees

No one assigned

Labels

skip news stdlib Standard Library Python modules in the Lib/ directory tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_traceback's PurePythonExceptionFormattingMixin does not fail correctly

2 participants

@iritkatriel @ncoghlan