Skip to content

Doc: C API: Fix Py_NewInterpreterFromConfig example code #126667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2024
Merged

Doc: C API: Fix Py_NewInterpreterFromConfig example code #126667

merged 1 commit into from
Nov 23, 2024

Conversation

@rhansen
Copy link
Contributor

@rhansen rhansen commented Nov 11, 2024 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Nov 11, 2024
ZeroIntensity
ZeroIntensity approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@ZeroIntensity
Copy link
Member

@Eclips4 I think you're fine to merge this. I'm quite certain this change is correct, and I really doubt that Eric would disagree. For precedent:

cpython/Modules/_testinternalcapi.c

Lines 1673 to 1674 in cc813e1

PyStatus status = Py_NewInterpreterFromConfig(&substate, &config);
if (PyStatus_Exception(status)) {

@Eclips4 Eclips4 merged commit e3038e9 into python:main Nov 23, 2024
25 checks passed
@miss-islington-app
Copy link

Thanks @rhansen for the PR, and @Eclips4 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 23, 2024
@rhansen @miss-islington
Doc: C API: Fix Py_NewInterpreterFromConfig example code (pythonGH-…
cca6636 
…126667)

(cherry picked from commit e3038e9)

Co-authored-by: Richard Hansen <rhansen@rhansen.org>
@bedevere-app
Copy link

bedevere-app bot commented Nov 23, 2024

GH-127201 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 23, 2024
@rhansen @miss-islington
Doc: C API: Fix Py_NewInterpreterFromConfig example code (pythonGH-…
6aa1ef3 
…126667)

(cherry picked from commit e3038e9)

Co-authored-by: Richard Hansen <rhansen@rhansen.org>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 23, 2024
@bedevere-app
Copy link

bedevere-app bot commented Nov 23, 2024

GH-127202 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Nov 23, 2024
Eclips4 pushed a commit that referenced this pull request Nov 23, 2024
@miss-islington @rhansen
[3.13] Doc: C API: Fix Py_NewInterpreterFromConfig example code (GH…
b1a241e 
…-126667) (#127201)

Doc: C API: Fix `Py_NewInterpreterFromConfig` example code (GH-126667)
(cherry picked from commit e3038e9)

Co-authored-by: Richard Hansen <rhansen@rhansen.org>
Eclips4 pushed a commit that referenced this pull request Nov 23, 2024
@miss-islington @rhansen
[3.12] Doc: C API: Fix Py_NewInterpreterFromConfig example code (GH…
6d2821c 
…-126667) (#127202)

Doc: C API: Fix `Py_NewInterpreterFromConfig` example code (GH-126667)
(cherry picked from commit e3038e9)

Co-authored-by: Richard Hansen <rhansen@rhansen.org>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@rhansen @ebonnal
Doc: C API: Fix Py_NewInterpreterFromConfig example code (python#12…
c1b5551 
…6667)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rhansen @ZeroIntensity @Eclips4