Skip to content

Conversation

SekaiArendelle
Copy link

@SekaiArendelle SekaiArendelle commented Nov 26, 2024

@ghost
Copy link

ghost commented Nov 26, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Nov 26, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! This needs a NEWS entry and a simple test (you'll probably need to add one to test_thread_pool).

I'm a little on the fence about this change, the timeout=2 feels a bit arbitrary, and I don't know how stable it is (this doesn't do anything for Linux, FWIW).

@SekaiArendelle
Copy link
Author

should we use platforms.system(), and even fix join further

@SekaiArendelle
Copy link
Author

it seems that there is no need to add a new dependence of platforms, I will have a try to add one to test.

@SekaiArendelle
Copy link
Author

it's hard for me to add a test, because the program can't know that he is blocked.

@SekaiArendelle
Copy link
Author

The problem of Thread.join have been fixed somewhere. Therefore, I'll close this issue.

@SekaiArendelle SekaiArendelle deleted the ready-to-pr branch February 9, 2025 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants