Skip to content

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Dec 5, 2024

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Dec 5, 2024
@graingert graingert marked this pull request as ready for review December 5, 2024 15:54
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a few small changes would be good.

Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your before/after should be capitalized as they introduce a new paragraph. To reduce the length of the text, how about putting ... on the same line as def?

@kumaraditya303 kumaraditya303 merged commit 0581e3f into python:main Dec 18, 2024
25 checks passed
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants