Skip to content

gh-127747: Resolve BytesWarning in test.support.strace_helper #127849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 14, 2024
Merged

gh-127747: Resolve BytesWarning in test.support.strace_helper #127849

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d02313
gh-127747: Use repr to normalize in strace_helper
cmaloney Dec 10, 2024
9bf31a6
gh-127747: Fix w/o strace and with -Werror
cmaloney Dec 12, 2024
e83dbfb
Review fixes
cmaloney Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions Lib/test/support/strace_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def _make_error(reason, details):
return StraceResult(
strace_returncode=-1,
python_returncode=-1,
event_bytes=f"error({reason},details={details}) = -1".encode('utf-8'),
event_bytes= f"error({reason},details={details!r}) = -1".encode('utf-8'),
stdout=res.out if res else b"",
stderr=res.err if res else b"")

Expand Down Expand Up @@ -179,9 +179,10 @@ def get_syscalls(code, strace_flags, prelude="", cleanup="",
@cache
def _can_strace():
res = strace_python("import sys; sys.exit(0)", [], check=False)
assert res.events(), "Should have parsed multiple calls"

return res.strace_returncode == 0 and res.python_returncode == 0
if res.strace_returncode == 0 and res.python_returncode == 0:
assert res.events(), "Should have parsed multiple calls"
return True
return False


def requires_strace():
Expand Down
Loading