Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Dec 16, 2024

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Dec 16, 2024
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Copy link
Contributor

@skirpichev skirpichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please add news and document that in whatsnew/3.14.rst (C API Changes->Deprecated).

@ghost ghost requested a review from skirpichev December 16, 2024 07:52
@ghost
Copy link
Author

ghost commented Dec 16, 2024

Thanks. Added news and whatsnew entry.

Copy link
Contributor

@skirpichev skirpichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I second on above suggestion.

Yuki Kobayashi and others added 3 commits December 16, 2024 19:14
@ghost ghost requested a review from encukou December 16, 2024 10:23
Alias for :c:func:`PySequence_Contains`.
.. deprecated:: 3.14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have this fancy thing these days:

Suggested change
.. deprecated:: 3.14
.. deprecated:: next

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do, and it makes backporting easier, but backporting a deprecation doesn't make much sense :)

@encukou encukou merged commit 52d552c into python:main Dec 16, 2024
25 checks passed
@ghost ghost deleted the doc-fix-2 branch December 16, 2024 14:40
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
…GH-127979)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

PySequence_In is not documented

3 participants