gh-126664: revert: Use else instead of finally in docs explaining "with"
#128169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… statement" documentation. (pythonGH-126665)" This reverts commit 25257d6.
gpshead
added
docs
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 22, 2024
…aining "with" (pythonGH-128169) Revert "pythongh-126664: Use `else` instead of `finally` in "The with statement" documentation. (pythonGH-126665)" This reverts commit 25257d6. (cherry picked from commit 228f275) Co-authored-by: Gregory P. Smith <greg@krypto.org>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 22, 2024
…aining "with" (pythonGH-128169) Revert "pythongh-126664: Use `else` instead of `finally` in "The with statement" documentation. (pythonGH-126665)" This reverts commit 25257d6. (cherry picked from commit 228f275) Co-authored-by: Gregory P. Smith <greg@krypto.org>
|
GH-128170 is a backport of this pull request to the 3.13 branch. |
|
GH-128171 is a backport of this pull request to the 3.12 branch. |
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Dec 23, 2024
…aining "with" (python#128169) Revert "pythongh-126664: Use `else` instead of `finally` in "The with statement" documentation. (pythonGH-126665)" This reverts commit 25257d6.
gpshead
added a commit
that referenced
this pull request
Dec 24, 2024
…laining "with" (GH-128169) (#128170) gh-126664: revert: Use `else` instead of `finally` in docs explaining "with" (GH-128169) Revert "gh-126664: Use `else` instead of `finally` in "The with statement" documentation. (GH-126665)" This reverts commit 25257d6. (cherry picked from commit 228f275) Co-authored-by: Gregory P. Smith <greg@krypto.org>
gpshead
added a commit
that referenced
this pull request
Dec 24, 2024
…laining "with" (GH-128169) (#128171) gh-126664: revert: Use `else` instead of `finally` in docs explaining "with" (GH-128169) Revert "gh-126664: Use `else` instead of `finally` in "The with statement" documentation. (GH-126665)" This reverts commit 25257d6. (cherry picked from commit 228f275) Co-authored-by: Gregory P. Smith <greg@krypto.org>
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
…aining "with" (python#128169) Revert "pythongh-126664: Use `else` instead of `finally` in "The with statement" documentation. (pythonGH-126665)" This reverts commit 25257d6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts docs commit 25257d6.
See #126665 (comment)
elseinstead offinallyin "The with statement" documentation. #126664📚 Documentation preview 📚: https://cpython-previews--128169.org.readthedocs.build/