Skip to content

gh-128617: Fix test_typing.test_readonly_inheritance #128618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2025
Merged

gh-128617: Fix test_typing.test_readonly_inheritance #128618

merged 1 commit into from
Jan 8, 2025

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jan 8, 2025 •
edited by bedevere-app bot
Loading

3.12 does not have ReadOnly, so skipping the backport.

@sobolevn sobolevn added skip news needs backport to 3.13 bugs and security fixes labels Jan 8, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jan 8, 2025
Closed
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review labels Jan 8, 2025
AlexWaygood
AlexWaygood approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is probably a bug in the typing_extensions test suite too.

@sobolevn
Copy link
Member Author

sobolevn commented Jan 8, 2025

Yes, fixing! https://github.com/python/typing_extensions/blob/15d48b2122dbb7124a3c3142222bc4647bb8ef4b/src/test_typing_extensions.py#L4626-L4633

@sobolevn sobolevn merged commit 971a52b into python:main Jan 8, 2025
48 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 8, 2025
@sobolevn @miss-islington
pythongh-128617: Fix test_typing.test_readonly_inheritance (pythonG…
4f7b1cc 
…H-128618)

(cherry picked from commit 971a52b)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Jan 8, 2025

GH-128622 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 8, 2025
sobolevn added a commit to sobolevn/typing_extensions that referenced this pull request Jan 8, 2025
@sobolevn
Fix test_typing.test_readonly_inheritance
e0a46ba 
Backport of python/cpython#128618
@sobolevn sobolevn mentioned this pull request Jan 8, 2025
Merged
sobolevn added a commit that referenced this pull request Jan 8, 2025
@miss-islington @sobolevn
[3.13] gh-128617: Fix test_typing.test_readonly_inheritance (GH-128618
c0ba0bc 
) (#128622)

gh-128617: Fix `test_typing.test_readonly_inheritance` (GH-128618)
(cherry picked from commit 971a52b)

Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sobolevn @AlexWaygood