Skip to content

gh-128397: Makes _delete attribute from TemporaryDirectory public #128643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-128397: Makes _delete attribute from TemporaryDirectory public #128643

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0b2f83
Made _delete public
Prtm2110 Jan 8, 2025
27bb251
Merge branch 'main' into tempdir_delete
Prtm2110 Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Lib/tempfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -900,12 +900,12 @@ class TemporaryDirectory:
def __init__(self, suffix=None, prefix=None, dir=None,
ignore_cleanup_errors=False, *, delete=True):
self.name = mkdtemp(suffix, prefix, dir)
self.delete = delete
self._ignore_cleanup_errors = ignore_cleanup_errors
self._delete = delete
self._finalizer = _weakref.finalize(
self, self._cleanup, self.name,
warn_message="Implicitly cleaning up {!r}".format(self),
ignore_errors=self._ignore_cleanup_errors, delete=self._delete)
ignore_errors=self._ignore_cleanup_errors, delete=self.delete)

@classmethod
def _rmtree(cls, name, ignore_errors=False, repeated=False):
Expand Down Expand Up @@ -962,7 +962,7 @@ def __enter__(self):
return self.name

def __exit__(self, exc, value, tb):
if self._delete:
if self.delete:
self.cleanup()

def cleanup(self):
Expand Down
Loading