Skip to content

gh-126137: improve docs for loop.add_reader and loop.add_writer #128666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 9, 2025
Merged

gh-126137: improve docs for loop.add_reader and loop.add_writer #128666

merged 5 commits into from
Jan 9, 2025

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jan 9, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jan 9, 2025
Closed
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir awaiting core review labels Jan 9, 2025
graingert
graingert reviewed Jan 9, 2025
View reviewed changes
@kumaraditya303 kumaraditya303 merged commit b2adf55 into python:main Jan 9, 2025
38 checks passed
@miss-islington-app
Copy link

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@kumaraditya303 kumaraditya303 deleted the docs-async branch January 9, 2025 10:11
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 9, 2025
@kumaraditya303 @miss-islington
pythongh-126137: improve docs for loop.add_reader and `loop.add_wri…
4de9534 
…ter` (pythonGH-128666)

(cherry picked from commit b2adf55)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Jan 9, 2025

GH-128667 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 9, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 9, 2025
@kumaraditya303 @miss-islington
pythongh-126137: improve docs for loop.add_reader and `loop.add_wri…
852280a 
…ter` (pythonGH-128666)

(cherry picked from commit b2adf55)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Jan 9, 2025

GH-128668 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jan 9, 2025
kumaraditya303 added a commit that referenced this pull request Jan 9, 2025
@miss-islington @kumaraditya303
[3.13] gh-126137: improve docs for loop.add_reader and `loop.add_wr…
1d2d62c 
…iter` (GH-128666) (#128667)

gh-126137: improve docs for `loop.add_reader` and `loop.add_writer` (GH-128666)
(cherry picked from commit b2adf55)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
kumaraditya303 added a commit that referenced this pull request Jan 9, 2025
@miss-islington @kumaraditya303
[3.12] gh-126137: improve docs for loop.add_reader and `loop.add_wr…
182234f 
…iter` (GH-128666) (#128668)

gh-126137: improve docs for `loop.add_reader` and `loop.add_writer` (GH-128666)
(cherry picked from commit b2adf55)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graingert graingert graingert approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news topic-asyncio

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kumaraditya303 @graingert