gh-129244: Remove workaround for MSVC compiler crash #129263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I guess the perf measurement target would be JIT and free-threaded builds if really needed, rather than default builds.) |
I think it might be useful in the future, but if it's not being used it may just bitrot, so probably better to remove it. I'll add that to this PR. |
zooba
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In earlier versions of MSVC, the compiler would crash when doing a PGO build due to the large size of
PyEval_EvalFrameDefault. This bug has been fixed upstream in MSVC, so we should remove our workaround.While this does re-enable optimizations on
PyEval_EvalFrameDefault, the performance gains on the benchmarks are unfortunately below the measurement threshold. Still worth doing without a performance benefit just to simplify things.