Skip to content

gh-129271: Fix reference leak with unicode writer in fast path in the json module #129272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 25, 2025
Merged

gh-129271: Fix reference leak with unicode writer in fast path in the json module #129272

merged 2 commits into from
Jan 25, 2025

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jan 25, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jan 25, 2025
Closed
@pablogsal pablogsal requested review from ambv and vstinner January 25, 2025 02:14
skirpichev
skirpichev reviewed Jan 25, 2025
View reviewed changes
vstinner
vstinner approved these changes Jan 25, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I confirm that it does fix the leak (I tested test_import).

@vstinner vstinner merged commit 7a54a65 into python:main Jan 25, 2025
44 checks passed
@vstinner
Copy link
Member

I merged your PR to repair Refleaks buildbots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skirpichev skirpichev skirpichev left review comments

@vstinner vstinner vstinner approved these changes

@ambv ambv Awaiting requested review from ambv

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pablogsal @vstinner @skirpichev