gh-129388: Use user supplied env vars when checking for gdbm deps #129389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use GDBM_CFLAGS and GDBM_LIBS for all gdbm related checks.
erlend-aasland
commented
Jan 28, 2025
Comment on lines
+4408
to
+4410
| dnl check for _dbmmodule.c dependencies | ||
| dnl ndbm, gdbm_compat, libdb | ||
| AC_CHECK_HEADERS([ndbm.h], [ |
There was a problem hiding this comment.
I think we're fine keeping this inside the GDBM_* env flag context, since this check also encompasses GDBM compat.
erlend-aasland
added
needs backport to 3.12
|
Hm, the fix is not so straightforward as I thought; I'll have to look more closely at this. |
|
Yeah interested in that CI failure — seems fine otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use GDBM_CFLAGS and GDBM_LIBS for all gdbm related checks.