Skip to content

GH-129382: change venv's API symlinks default to match the CLI #129493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

GH-129382: change venv's API symlinks default to match the CLI #129493

wants to merge 7 commits into from

Conversation

FFY00
Copy link
Member

@FFY00 FFY00 commented Jan 31, 2025 •
edited by github-actions bot
Loading

@FFY00
pythonGH-129382: change venv's API symlinks default to match the CLI
5017d1b 
Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00 FFY00 requested a review from vsajip as a code owner January 31, 2025 02:28
@bedevere-app bedevere-app bot mentioned this pull request Jan 31, 2025
Open
@zanieb
Copy link
Contributor

zanieb commented Jan 31, 2025

Thank you!

@geofft
Copy link
Contributor

geofft commented Jan 31, 2025

create() (line 606) also needs its defaults adjusted.

@FFY00
Copy link
Member Author

FFY00 commented Jan 31, 2025

Ah, yes, thanks for catching that!

FFY00 added 2 commits January 31, 2025 09:02
@FFY00
Fix venv.create
60ec1d6 
Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00
Add test to make sure the defaults match in venv.create and EnvBuilder
6fbc56c 
Signed-off-by: Filipe Laíns <lains@riseup.net>
vsajip
vsajip requested changes Jan 31, 2025
View reviewed changes
Copy link
Member

@vsajip vsajip left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per comment re. Misc/NEWS entry, and also the macOS and other build failures need addressing.

@bedevere-app
Copy link

bedevere-app bot commented Jan 31, 2025

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@geofft geofft mentioned this pull request Jan 31, 2025
Open
@zanieb
Copy link
Contributor

zanieb commented Mar 21, 2025

@FFY00 do you need help following up on this one?

FFY00 added 4 commits April 2, 2025 06:05
@FFY00
Mention venv.create in the news
7157fa4 
Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00
Merge branch 'main' into pythongh-129382
c715439
@FFY00
Fix tests expecting --copies on Windows, which is now the default
d4bbbd0 
Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00
Fix news typo
2e22d18 
Signed-off-by: Filipe Laíns <lains@riseup.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip vsajip requested changes

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@FFY00 @zanieb @geofft @vsajip