Skip to content

gh-130177: Fix skipped tests in test_gettext #130178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2025
Merged

gh-130177: Fix skipped tests in test_gettext #130178

merged 1 commit into from
Feb 16, 2025

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Feb 16, 2025 •
edited by bedevere-app bot
Loading

Running test_gettext before:

Total tests: run=37

and after:

Total tests: run=57

@tomasr8 tomasr8 added skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Feb 16, 2025
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting review labels Feb 16, 2025
@bedevere-app bedevere-app bot mentioned this pull request Feb 16, 2025
Closed
@StanFromIreland
Copy link
Member

@serhiy-storchaka You were last to modify them a few years ago, just checking this wasn't intentional for some reason?

serhiy-storchaka
serhiy-storchaka approved these changes Feb 16, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is my mistake made in 326c6c4.

Thanks, @tomasr8.

@serhiy-storchaka serhiy-storchaka merged commit 2e8044a into python:main Feb 16, 2025
52 checks passed
@miss-islington-app
Copy link

Thanks @tomasr8 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 16, 2025
@tomasr8 @miss-islington
pythongh-130177: Fix unintentionally skipped tests in test_gettext (p…
bcbc5a5 
…ythonGH-130178)

(cherry picked from commit 2e8044a)

Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 16, 2025

GH-130183 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 16, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 16, 2025
@tomasr8 @miss-islington
pythongh-130177: Fix unintentionally skipped tests in test_gettext (p…
d2898c9 
…ythonGH-130178)

(cherry picked from commit 2e8044a)

Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 16, 2025

GH-130184 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 16, 2025
@tomasr8 tomasr8 deleted the gettext-tests branch February 16, 2025 12:25
serhiy-storchaka pushed a commit that referenced this pull request Feb 16, 2025
@miss-islington @tomasr8
[3.12] gh-130177: Fix unintentionally skipped tests in test_gettext (G…
b85f061 
…H-130178) (GH-130184)

(cherry picked from commit 2e8044a)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
serhiy-storchaka pushed a commit that referenced this pull request Feb 16, 2025
@miss-islington @tomasr8
[3.13] gh-130177: Fix unintentionally skipped tests in test_gettext (G…
5d240c7 
…H-130178) (GH-130183)

(cherry picked from commit 2e8044a)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tomasr8 @StanFromIreland @serhiy-storchaka