Skip to content

gh-130193: Increase test coverage of gettext.c2py #130208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2025
Merged

gh-130193: Increase test coverage of gettext.c2py #130208

merged 1 commit into from
Feb 17, 2025

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Feb 16, 2025 •
edited by bedevere-app bot
Loading

@tomasr8 tomasr8 added skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Feb 16, 2025
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting review labels Feb 16, 2025
@bedevere-app bedevere-app bot mentioned this pull request Feb 16, 2025
Closed
serhiy-storchaka
serhiy-storchaka approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit fb2d325 into python:main Feb 17, 2025
52 checks passed
@miss-islington-app
Copy link

Thanks @tomasr8 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 17, 2025
@tomasr8 @miss-islington
pythongh-130193: Increase test coverage of gettext.c2py (pythonGH-130208
476b7ef 
)

(cherry picked from commit fb2d325)

Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 17, 2025

GH-130217 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 17, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 17, 2025
@tomasr8 @miss-islington
pythongh-130193: Increase test coverage of gettext.c2py (pythonGH-130208
ba3dcbd 
)

(cherry picked from commit fb2d325)

Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 17, 2025

GH-130218 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 17, 2025
@tomasr8 tomasr8 deleted the c2py-coverage branch February 17, 2025 09:04
serhiy-storchaka pushed a commit that referenced this pull request Feb 17, 2025
@miss-islington @tomasr8
[3.12] gh-130193: Increase test coverage of gettext.c2py (GH-130208) (G…
fc1c35f 
…H-130218)

(cherry picked from commit fb2d325)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
serhiy-storchaka pushed a commit that referenced this pull request Feb 17, 2025
@miss-islington @tomasr8
[3.13] gh-130193: Increase test coverage of gettext.c2py (GH-130208) (G…
1b2cfb7 
…H-130217)

(cherry picked from commit fb2d325)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomasr8 @serhiy-storchaka