Skip to content

gh-130618: Fix parser error when using lambdas inside f-strings #130638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

gh-130618: Fix parser error when using lambdas inside f-strings #130638

merged 1 commit into from
Feb 27, 2025

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Feb 27, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Feb 27, 2025
Closed
@pablogsal pablogsal added the needs backport to 3.13 bugs and security fixes label Feb 27, 2025
lysnikolaou
lysnikolaou approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@pablogsal pablogsal merged commit e06bebb into python:main Feb 27, 2025
48 checks passed
@pablogsal pablogsal deleted the gh-130618 branch February 27, 2025 15:51
@miss-islington-app
Copy link

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @pablogsal, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e06bebb87e1b33f7251196e1ddb566f528c3fc98 3.13

@pablogsal pablogsal added the needs backport to 3.12 only security fixes label Feb 27, 2025
@miss-islington-app
Copy link

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @pablogsal, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e06bebb87e1b33f7251196e1ddb566f528c3fc98 3.12

pablogsal added a commit to pablogsal/cpython that referenced this pull request Feb 27, 2025
@pablogsal
pythongh-130618: Fix parser error when using lambdas inside f-strings (…
43cd39d 
…python#130638)

(cherry picked from commit e06bebb)
pablogsal added a commit to pablogsal/cpython that referenced this pull request Feb 27, 2025
@pablogsal
[3.13] pythongh-130618: Fix parser error when using lambdas inside f-…
e654b87 
…strings (pythonGH-130638)

(cherry picked from commit e06bebb)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit to pablogsal/cpython that referenced this pull request Feb 27, 2025
@pablogsal
[3.13] pythongh-130618: Fix parser error when using lambdas inside f-…
b13a3cd 
…strings (pythonGH-130638)

(cherry picked from commit e06bebb)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 27, 2025

GH-130642 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 27, 2025
pablogsal added a commit to pablogsal/cpython that referenced this pull request Feb 27, 2025
@pablogsal
[3.13] pythongh-130618: Fix parser error when using lambdas inside f-…
91ab8b2 
…strings (pythonGH-130638)

(cherry picked from commit e06bebb)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
pablogsal added a commit to pablogsal/cpython that referenced this pull request Feb 27, 2025
@pablogsal
[3.12] pythongh-130618: Fix parser error when using lambdas inside f-…
e5f77fb 
…strings (pythonGH-130638)

(cherry picked from commit e06bebb)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Feb 27, 2025

GH-130644 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 27, 2025
pablogsal added a commit that referenced this pull request Mar 1, 2025
@pablogsal
[3.13] gh-130618: Fix parser error when using lambdas inside f-strings (
2d7145d 
GH-130638) (#130642)

(cherry picked from commit e06bebb)

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Mar 1, 2025
@pablogsal
[3.12] gh-130618: Fix parser error when using lambdas inside f-strings (
0860d9c 
GH-130638) (#130644)

(cherry picked from commit e06bebb)
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@pablogsal @seehwan80
pythongh-130618: Fix parser error when using lambdas inside f-strings (…
6ed401e 
…python#130638)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

Assignees

@pablogsal pablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pablogsal @lysnikolaou