gh-130730: Fix flaky test_active_children test
#130731
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use an Event object instead of time.sleep().
zanieb
approved these changes
Mar 1, 2025
There was a problem hiding this comment.
Seems worth auditing all the uses of DELTA here, e.g.,
cpython/Lib/test/_test_multiprocessing.py
Lines 1232 to 1233 in 28b6274
Let me know if you want help with that.
|
@zanieb - yes, thanks! I'd appreciate help with that. |
|
Closing in favor of #130837 |
|
Sorry, I didn't see that you already created a PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an Event object instead of time.sleep().
test_active_childrenmultiprocessing test is flaky #130730