[3.12] gh-131181: Add some non-NULL assertion checks in Modules/_ctypes/_ctypes.c
#131188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
PyCData_NewGetBuffer()
(fileModules/_ctypes/_ctypes.c
), thePyObject_stgdict()
is called, which may return NULL.Its result is assigned to
dict
, thendict
is dereferenced (view->format = dict->format ? dict->format : "B";
).If
dict
is NULL, a null pointer dereference will occur, so a check for NULL need to be added.Similarly, in the
PyCData_reduce()
(fileModules/_ctypes/_ctypes.c
)PyObject_stgdict(myself)
may return NULL, so need to check result to prevent null pointer dereferencing.Commit dcaf33a (Author: @encukou) fixes this problems, but it is very large and probably difficult to backport, so I suggest adding
assert();
before the dereference.This needs to be added to branches 3.1 - 3.12.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Modules/_ctypes/_ctypes.c
#131181