Skip to content

Conversation

rialbat
Copy link
Contributor

@rialbat rialbat commented Mar 24, 2025

Combining conditions with the same result code.

@ghost
Copy link

ghost commented Mar 24, 2025

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Mar 24, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks a lot for your work (this is the first commit, yey!)
But, this is consider a stylistic-only change. We try to keep the amount of such changes as low as possible in CPython's codebase. Because they can introduce bugs, create possible merge and backport conflicts, and ruin git history.

All such changes are merged based on module maintainer's decision :)

However, thanks again for noticing this!

@rhettinger
Copy link
Contributor

I'm going to decline this one. It is a minor stylistic edit. In general we defer to the original author on matters of style. Also, in this particular case I think the edit makes the code harder to read. It doesn't look nice.

@rhettinger rhettinger closed this Mar 24, 2025
@rialbat rialbat deleted the remove-identical-branch branch March 26, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants