Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/random.py
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ def __init_subclass__(cls, /, **kwargs):
def _randbelow_with_getrandbits(self, n):
"Return a random int in the range [0,n). Defined for n > 0."

k = n.bit_length()
k = (n - 1).bit_length()
r = self.getrandbits(k) # 0 <= r < 2**k
while r >= n:
r = self.getrandbits(k)
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_random.py
Original file line number Diff line number Diff line change
Expand Up @@ -813,7 +813,7 @@ def test_randrange_uses_getrandbits(self):
self.gen.seed(1234567)
# If randrange uses getrandbits, it should pick getrandbits(100)
# when called with a 100-bits stop argument.
self.assertEqual(self.gen.randrange(2**99),
self.assertEqual(self.gen.randrange(2**99 + 1),
97904845777343510404718956115)

def test_randbelow_logic(self, _log=log, int=int):
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
20-30% performance improvement when generating integers lower than some power of 2. E.g. :func:`!random.randint(0, 2**32-1)`
Loading