Skip to content

[3.13] gh-130052: Fix search_map_for_section() error handling (GH-132594) #132598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

[3.13] gh-130052: Fix search_map_for_section() error handling (GH-132594) #132598

merged 1 commit into from
Apr 16, 2025

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Apr 16, 2025 •
edited by bedevere-app bot
Loading

  • Don't call close() if the file descriptor is negative.
  • If close() fails, chain the existing exception.
    (cherry picked from commit 014c7f9)

Co-authored-by: Victor Stinner vstinner@python.org

@vstinner @miss-islington
pythongh-130052: Fix search_map_for_section() error handling (pythonG…
0a8a5ee 
…H-132594)

* Don't call close() if the file descriptor is negative.
* If close() fails, chain the existing exception.
(cherry picked from commit 014c7f9)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Apr 16, 2025
@bedevere-app bedevere-app bot mentioned this pull request Apr 16, 2025
Closed
@bedevere-app bedevere-app bot mentioned this pull request Apr 16, 2025
Merged
@vstinner vstinner enabled auto-merge (squash) April 16, 2025 13:58
@vstinner vstinner merged commit ff3f658 into python:3.13 Apr 16, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@miss-islington @vstinner