[3.13] typing docs: Clarify Protocol / runtime_checkable docs (GH-132606) #132607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Explicitly say that isinstance/issubclass do not work on non-runtime checkable protocols. - Move the sentence "This raises TypeError when applied to a non-protocol class". It took me quite some time to decide what "this" was here: it refers to applying the decorator, not to an isinstance() call. (cherry picked from commit 14efcad) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
miss-islington
requested review from
AlexWaygood and
JelleZijlstra
as code owners
bedevere-app
bot
added
awaiting review
docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
protocols.
took me quite some time to decide what "this" was here: it refers to applying the
decorator, not to an isinstance() call.
(cherry picked from commit 14efcad)
Co-authored-by: Jelle Zijlstra jelle.zijlstra@gmail.com
Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com
📚 Documentation preview 📚: https://cpython-previews--132607.org.readthedocs.build/