Skip to content

gh-132608: Fix a sample code coloring for ast.While #132609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2025
Merged

gh-132608: Fix a sample code coloring for ast.While #132609

merged 2 commits into from
Apr 16, 2025

Conversation

Tan90909090
Copy link
Contributor

@Tan90909090 Tan90909090 commented Apr 16, 2025 •
edited by github-actions bot
Loading

Fixes #132608. I added a > character.

I executed make venv and make html according to Building the documentation, then I confirmed that the sample code for ast.While is colored correctly now:

image

📚 Documentation preview 📚: https://cpython-previews--132609.org.readthedocs.build/

@python-cla-bot
Copy link

python-cla-bot bot commented Apr 16, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Apr 16, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Apr 16, 2025
@bedevere-app bedevere-app bot mentioned this pull request Apr 16, 2025
Closed
@terryjreedy
Copy link
Member

I will merge this when you sign the required CLA.

@Tan90909090
Copy link
Contributor Author

I've signed to Contributor License Agreement.

@AA-Turner AA-Turner added the needs backport to 3.13 bugs and security fixes label Apr 16, 2025
@StanFromIreland
Copy link
Member

It will update the status if you close/reopen the pr

@Tan90909090
Copy link
Contributor Author

I will close the PR temporarily.

@Tan90909090
Copy link
Contributor Author

And reopen.

@Tan90909090 Tan90909090 reopened this Apr 16, 2025
@terryjreedy terryjreedy added needs backport to 3.13 bugs and security fixes and removed needs backport to 3.13 bugs and security fixes labels Apr 16, 2025
@terryjreedy terryjreedy enabled auto-merge (squash) April 16, 2025 19:19
@terryjreedy terryjreedy disabled auto-merge April 16, 2025 19:19
@terryjreedy terryjreedy changed the title gh-132608: Fix a sample code's coloring for ast.While gh-132608: Fix a sample code coloring for ast.While Apr 16, 2025
@terryjreedy terryjreedy enabled auto-merge (squash) April 16, 2025 19:20
@terryjreedy terryjreedy merged commit f5512a2 into python:main Apr 16, 2025
28 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Apr 16, 2025
@miss-islington-app
Copy link

Thanks @Tan90909090 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 16, 2025
@Tan90909090 @miss-islington
pythongh-132608: Fix a sample code coloring for ast.While (pythonGH-1…
665ab43 
…32609)

Add missing '>' in prompt.
(cherry picked from commit f5512a2)

Co-authored-by: Tan90909090 <tan9tan@live.jp>
@bedevere-app
Copy link

bedevere-app bot commented Apr 16, 2025

GH-132612 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 16, 2025
@StanFromIreland
Copy link
Member

StanFromIreland commented Apr 16, 2025 •
edited
Loading

@Tan90909090 Congratulations on your first contribution to cpython, if you would like to contribute again, there are ~7k issues open ;-) The devguide has a lot of useful information.

AA-Turner pushed a commit that referenced this pull request Apr 16, 2025
@miss-islington
[3.13] gh-132608: Fix a sample code coloring for ast.While (GH-132609) (
db7ad1c 
#132612)
hrnciar pushed a commit to fedora-python/cpython that referenced this pull request Apr 17, 2025
@miss-islington @hrnciar
00457: pythongh-132608: Fix a sample code coloring for ast.While (pyt…
b18e6bf 
…honGH-132609) (python#132612)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner AA-Turner approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

A sample code for ast.While should be colored correctly like the other examples.

4 participants

@Tan90909090 @terryjreedy @StanFromIreland @AA-Turner