Skip to content

gh-132686: Add parameters inherit_class_doc and fallback_to_class_doc for inspect.getdoc() #132691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-132686: Add parameters inherit_class_doc and fallback_to_class_doc for inspect.getdoc() #132691

wants to merge 1 commit into from

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Apr 18, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 18, 2025
Open
Carreau
Carreau approved these changes Apr 19, 2025
View reviewed changes
Copy link
Contributor

@Carreau Carreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seem reasonable to me.

The only extra info that might be useful is to return wether doc was found on superclass/type instead of object itself, but that would change API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Carreau Carreau Carreau approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka @Carreau