Skip to content

Conversation

dzherb
Copy link

@dzherb dzherb commented Apr 21, 2025

@dzherb dzherb requested review from AA-Turner and hugovk as code owners April 21, 2025 18:33
@python-cla-bot
Copy link

python-cla-bot bot commented Apr 21, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Apr 21, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@dzherb
Copy link
Author

dzherb commented Apr 21, 2025

I'm not sure if I should also commit the autogenerated topics.py

@dzherb
Copy link
Author

dzherb commented Apr 21, 2025

This test case fails not due to unsorted keywords, but because match and case are not present in keyword.kwlist. Instead, they are listed in keyword.softkwlist, along with entries like type and _.

class TestHelper(unittest.TestCase):
    def test_keywords(self):
        self.assertEqual(sorted(pydoc.Helper.keywords),
                         sorted(keyword.kwlist))

I suggest splitting this into two separate cases:

class TestHelper(unittest.TestCase):
    def test_keywords_are_sorted(self):
        self.assertEqual(
            sorted(pydoc.Helper.keywords),
            list(pydoc.Helper.keywords),
        )

    def test_keywords_in_grammar(self):
        all_keywords = set(keyword.kwlist) | set(keyword.softkwlist)
        for kw in pydoc.Helper.keywords:
            self.assertIn(kw, all_keywords)

@bedevere-app
Copy link

bedevere-app bot commented May 5, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out this PR and tried:

Снимок экрана 2025-05-06 в 15 21 31

I think that you need to regen pydoc-topics with: make -C Doc pydoc-topics

It might take a while.

Also, add a NEWS entry (see #132784 (comment) about how to do that) and change the issue number :) I will update you PR title for you to match the original issue #132783

@sobolevn sobolevn changed the title gh-132783: Add match and case to help topics gh-105895: Add match and case to help topics May 6, 2025
@bedevere-app
Copy link

bedevere-app bot commented May 6, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@dzherb dzherb requested a review from sobolevn May 7, 2025 11:57
@dzherb
Copy link
Author

dzherb commented May 9, 2025

@sobolevn could you please look at the last changes? Is everything ok?

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I can't merge this PR. Since I am not an expert in pydoc and I need someone who knows how it actually works to verify :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants