-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
gh-105895: Add match
and case
to help
topics
#132784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
I'm not sure if I should also commit the autogenerated |
This test case fails not due to unsorted keywords, but because class TestHelper(unittest.TestCase):
def test_keywords(self):
self.assertEqual(sorted(pydoc.Helper.keywords),
sorted(keyword.kwlist)) I suggest splitting this into two separate cases: class TestHelper(unittest.TestCase):
def test_keywords_are_sorted(self):
self.assertEqual(
sorted(pydoc.Helper.keywords),
list(pydoc.Helper.keywords),
)
def test_keywords_in_grammar(self):
all_keywords = set(keyword.kwlist) | set(keyword.softkwlist)
for kw in pydoc.Helper.keywords:
self.assertIn(kw, all_keywords) |
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked out this PR and tried:

I think that you need to regen pydoc-topics
with: make -C Doc pydoc-topics
It might take a while.
Also, add a NEWS entry (see #132784 (comment) about how to do that) and change the issue number :) I will update you PR title for you to match the original issue #132783
match
and case
to help
topicsmatch
and case
to help
topics
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
# Conflicts: # Lib/pydoc_data/topics.py
@sobolevn could you please look at the last changes? Is everything ok? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I can't merge this PR. Since I am not an expert in pydoc
and I need someone who knows how it actually works to verify :)
help
seems to have no information onmatch
orcase
#105895📚 Documentation preview 📚: https://cpython-previews--132784.org.readthedocs.build/
help
seems to have no information onmatch
orcase
#105895