gh-133376: build: allow parser.c to be created if missing #133378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dura0ok
changed the title
during regen-pegen Previously, `regen-pegen` would fail if Parser/parser.c was deleted (e.g. due to merge conflicts), requiring a manual `touch` to proceed. This change passes `--create` to update_file.py to allow the file to be created automatically if it doesn't exist.
sobolevn
approved these changes
May 4, 2025
There was a problem hiding this comment.
I think that this is better. But, maybe there are some other reasons why this is not default? Let's wait for @lysnikolaou and @pablogsal to double check :)
|
I cannot think of any reason I think it was just adapted from somewhere else. This is a good improvement |
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
regen-pegenwould fail if Parser/parser.c was deleted (e.g. due to merge conflicts), requiring a manualtouchto proceed. This change passes--createto update_file.py to allow the file to be created automatically if it doesn't exist.make regen-pegenDX on merge conflicts #133376