[GH-133419] fix test_external_inspection race assert #133422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
either line could be where the inspection finds the foo() function as after ready is sent, the process may not have made progress onto the next line yet. "solve" by putting the statements on the same line.
|
This change doesn't fix all tests, it's incomplete. I wrote #133433 to fix more tests. |
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…3422) [tests] fix test_external_inspection race assert either line could be where the inspection finds the foo() function as after ready is sent, the process may not have made progress onto the next line yet. "solve" by putting the statements on the same line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
either line could be where the inspection finds the foo() function as after ready is sent, the process may not have made progress onto the next line yet. "solve" by putting the statements on the same line. simpler than asserting for multiple possible line values.
Fixes #133419.
Closes #133419.
test_external_inspectionfails on Ubuntu #133419