gh-133517: Remove os.listdrive, os.listvolumes and os.listmounts in non windows desktop builds #133518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbachmann
changed the title
maxbachmann
changed the title
|
This is ready for review now |
chris-eibl
reviewed
May 7, 2025
Misc/NEWS.d/next/Library/2025-05-06-14-44-55.gh-issue-133517.Ca6NgW.rst
Outdated
Show resolved
Hide resolved
|
LGTM. Pinging @zooba for final steps. |
…a6NgW.rst Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
zooba
reviewed
May 7, 2025
zooba
approved these changes
May 7, 2025
I don't need a backport myself. We have a patched version of Cpython anyway and just drop the patches when we upgrade to a version that includes the changes. |
|
Well, the offer of a backport is there if someone says they need it. But if not, let's not bother. |
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…s in non-desktop Windows builds (pythonGH-133518)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.