gh-133357: Add anti-regression test for caret location in error message #133848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanFromIreland
changed the title
|
@ZeroIntensity we need a skip-news here |
sobolevn
reviewed
May 10, 2025
|
I agree with @sobolevn. Let's not add a test like this, it will just slightly complicate us improving this in the future. Thanks for the PR @StanFromIreland, but I'm gonna close it fow now. We can always reopen it if someone feels strongly about this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was concluded that it will be kept as it is in #133455 (comment).
To ensure it does not change again, let's actually test it.
Invalid star expression#133357