Skip to content

Conversation

StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented May 10, 2025

Before:

>>> def func1(uhoh nocomma): pass
  File "<python-input-0>", line 1
    def func1(uhoh nocomma): pass
                  ^^^^^^^
SyntaxError: invalid syntax

Now:

>>> def func2(uhoh nocomma): pass
  File "<python-input-0>", line 1
    def func2(uhoh nocomma): pass
              ^^^^^^^^^^^^
SyntaxError: expected comma between parameters

@python python locked and limited conversation to collaborators May 10, 2025
@ZeroIntensity

This comment was marked as outdated.

@python python unlocked this conversation May 10, 2025
@StanFromIreland
Copy link
Member Author

@sobolevn Maybe you would be interested in reviewing?

Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar change works, but I cannot verify that is 'most correct' possible.

@bedevere-app
Copy link

bedevere-app bot commented May 14, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

@StanFromIreland StanFromIreland requested a review from pablogsal May 14, 2025 15:46
@terryjreedy terryjreedy dismissed their stale review May 14, 2025 20:43

Command and change request were wrong.

@terryjreedy
Copy link
Member

Continues to work for me after simplification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants