bpo-36878: Track extra text added to 'type: ignore' in the AST #13479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
approved these changes
May 22, 2019
jonafato
added a commit
to jonafato/typeshed
that referenced
this pull request
Apr 22, 2021
This attribute was [added in 3.8]. This change lets mypy resolve the type correctly instead of failing with an attr-defined error. [added in 3.8]: python/cpython#13479
hauntsaninja
pushed a commit
to python/typeshed
that referenced
this pull request
Apr 22, 2021
This attribute was [added in 3.8]. This change lets mypy resolve the type correctly instead of failing with an attr-defined error. [added in 3.8]: python/cpython#13479
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13238 made extra text after a
# type: ignoreaccepted by the parser.This finishes the job and actually plumbs the extra text through the
parser and makes it available in the AST.
https://bugs.python.org/issue36878