Skip to content

Conversation

ppwwyyxx
Copy link
Contributor

@ppwwyyxx ppwwyyxx commented Oct 11, 2025

The following tests pass:

./python -m test -v test_unittest

@ppwwyyxx ppwwyyxx requested a review from cjw296 as a code owner October 11, 2025 05:15
@python-cla-bot
Copy link

python-cla-bot bot commented Oct 11, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

Copy link
Contributor

@cjw296 cjw296 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at your original issue, it appears that your problems there are better addressed without changes to the Python core codebase?

Apologies if I'm misreading that.

@bedevere-app
Copy link

bedevere-app bot commented Oct 11, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ppwwyyxx
Copy link
Contributor Author

We deliberately want to run certain resource-heavy tests in some cases, so the suggestion to use less resource is not ideal. Regardless, I suppose avoiding ref cycle is a general improvement worth adding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants