gh-140082: Forward colorizing from libregrtest to unittest #140083
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libregrtest redirects test output to a file as part of its operation. When `unittest` checks to see if it should colorize with `isatty(sys.stdout)` that fails resulting in no colorizing of the unittest output. Update `libregrtest` to set `FORCE_COLOR=1` when redirecting test output so that unittest will do color printing.
|
I think this can be skip news as it's a strictly internal change / libregrtest isn't externally exposed |
vstinner
reviewed
Oct 14, 2025
|
You might add a NEWS entry in the Tests category. |
vstinner
reviewed
Oct 15, 2025
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
reviewed
Oct 16, 2025
| random.seed(runtests.random_seed) | ||
|
|
||
| if can_colorize(file=sys.stdout): | ||
| os.environ['FORCE_COLOR'] = "1" |
There was a problem hiding this comment.
This change is not needed to get colors with ./python -m test -W -j0 (...) command.
There was a problem hiding this comment.
Correct, -j0 results in multi-worker mode where this code isn't run, instead the worker.py code is used. This is only used in single process mode ex. ./python -m test -W --single-process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libregrtestredirects test output to a file as part of its operation. Whenunittestchecks to see if it should colorize withisatty(sys.stdout)that returns False resulting in no colorizing of theunittestoutput.Update
libregrtestto setFORCE_COLOR=1when redirecting test output so thatunittestwill do color printing.python -m test -W#140082