Update documented minimum required zlib library version #140116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanFromIreland
requested review from
AA-Turner,
corona10,
emmatyping and
erlend-aasland
as code owners
bedevere-app
bot
added
docs
StanFromIreland
commented
Oct 14, 2025
|
|
||
| * `libb2 <https://github.com/BLAKE2/libb2>`_ (:ref:`BLAKE2 <hashlib-blake2>`), | ||
| used by :mod:`hashlib` module. | ||
| * `libb2 <https://github.com/BLAKE2/libb2>`_ (:ref:`BLAKE2 <hashlib-blake2>`) |
Member
Author
There was a problem hiding this comment.
I removed some unnecessary commas here.
StanFromIreland
commented
Oct 14, 2025
| incompatibilities between the Python module and versions of the zlib library | ||
| earlier than 1.1.3; 1.1.3 has a `security vulnerability <https://zlib.net/zlib_faq.html#faq33>`_, so we recommend using | ||
| 1.1.4 or later. | ||
| has its own home page at https://www.zlib.net. zlib 1.2.2.1 is the minium |
Member
Author
There was a problem hiding this comment.
This was wrong for a while:
Lines 16 to 18 in 59547a2
vstinner
reviewed
Oct 14, 2025
| * `Tcl/Tk <https://www.tcl-lang.org/>`_ 8.5.12 for the :mod:`tkinter` module. | ||
|
|
||
| * `zlib <https://www.zlib.net>`_ 1.1.4 is the reccomended minimum version for the | ||
| * `zlib <https://www.zlib.net>`_ 1.2.2.1 is the minimum version for the |
Member
There was a problem hiding this comment.
zlib 1.2.2.0 was released in 2004: https://madler.net/pipermail/zlib-announce_madler.net/2004/000002.html. So it sounds reasonable to require this (old) version.
Member
Author
There was a problem hiding this comment.
As I noted here, it is required by the code. One will get an error otherwise.
Member
|
Merged, thanks. |
Member
|
#141204 effectively backports this to 3.14. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--140116.org.readthedocs.build/