-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
gh-140189: Add CI job to test iOS builds. #140190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
freakboy3742
wants to merge
9
commits into
python:main
Choose a base branch
from
freakboy3742:ios-ci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+82
−9
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ebe0470
Add CI job to test iOS builds.
freakboy3742 e1f19c7
Enable line buffering in framework build scripts.
freakboy3742 4193eed
Switch to macos-14 runner.
freakboy3742 a30fa83
Correct naming of SE simulator.
freakboy3742 22e3968
Revert to macos-15 runnner.
freakboy3742 5103ac7
Simplify build artefact in 'fast' mode.
freakboy3742 6ed3dcf
Normalize the slow/fast argument for CI execution.
freakboy3742 57300c3
Explicitly use --fast-ci mode in CI config.
freakboy3742 782dbab
Merge branch 'main' into ios-ci
freakboy3742 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -414,6 +414,35 @@ jobs: | |||||||||||||
- name: Build and test | ||||||||||||||
run: ./Android/android.py ci --fast-ci ${{ matrix.arch }}-linux-android | ||||||||||||||
|
||||||||||||||
build-ios: | ||||||||||||||
name: iOS (${{ matrix.arch }}) | ||||||||||||||
needs: build-context | ||||||||||||||
if: needs.build-context.outputs.run-tests == 'true' | ||||||||||||||
timeout-minutes: 60 | ||||||||||||||
strategy: | ||||||||||||||
fail-fast: false | ||||||||||||||
matrix: | ||||||||||||||
include: | ||||||||||||||
- arch: aarch64 | ||||||||||||||
runs-on: macos-15 | ||||||||||||||
runs-on: ${{ matrix.runs-on }} | ||||||||||||||
Comment on lines
+424
to
+428
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In fact, And we can use
Suggested change
|
||||||||||||||
steps: | ||||||||||||||
- uses: actions/checkout@v4 | ||||||||||||||
with: | ||||||||||||||
persist-credentials: false | ||||||||||||||
|
||||||||||||||
# GitHub recommends explicitly selecting the desired Xcode version: | ||||||||||||||
# https://github.com/actions/runner-images/issues/12541#issuecomment-3083850140 | ||||||||||||||
# This became a necessity as a result of | ||||||||||||||
# https://github.com/actions/runner-images/issues/12541 and | ||||||||||||||
# https://github.com/actions/runner-images/issues/12751. | ||||||||||||||
- name: Select Xcode version | ||||||||||||||
run: | | ||||||||||||||
sudo xcode-select --switch /Applications/Xcode_16.4.app | ||||||||||||||
- name: Build and test | ||||||||||||||
run: python3 Apple ci iOS --fast-ci --simulator 'iPhone 16e,OS=18.5' | ||||||||||||||
|
||||||||||||||
build-wasi: | ||||||||||||||
name: 'WASI' | ||||||||||||||
needs: build-context | ||||||||||||||
|
@@ -723,6 +752,7 @@ jobs: | |||||||||||||
- build-ubuntu-ssltests-awslc | ||||||||||||||
- build-ubuntu-ssltests-openssl | ||||||||||||||
- build-android | ||||||||||||||
- build-ios | ||||||||||||||
- build-wasi | ||||||||||||||
- test-hypothesis | ||||||||||||||
- build-asan | ||||||||||||||
|
@@ -759,6 +789,7 @@ jobs: | |||||||||||||
build-ubuntu-ssltests-awslc, | ||||||||||||||
build-ubuntu-ssltests-openssl, | ||||||||||||||
build-android, | ||||||||||||||
build-ios, | ||||||||||||||
build-wasi, | ||||||||||||||
test-hypothesis, | ||||||||||||||
build-asan, | ||||||||||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Build/2025-10-16-11-30-53.gh-issue-140189.YCrUyt.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
iOS builds were added to CI. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We include the
arch
for Android to differentiate the two, so can skip it here: